Skip to content

fix(cdk-examples): improve dark theme visibility in menu, overlay, an…#33367

Merged
crisbeto merged 1 commit into
angular:mainfrom
BHUVANSH855:fix-dark-theme-example-visibility
Jun 12, 2026
Merged

fix(cdk-examples): improve dark theme visibility in menu, overlay, an…#33367
crisbeto merged 1 commit into
angular:mainfrom
BHUVANSH855:fix-dark-theme-example-visibility

Conversation

@BHUVANSH855

Copy link
Copy Markdown
Contributor

Summary

This PR improves the visibility of example components in dark theme across several CDK examples:

  • Menu examples: Standalone trigger and nested context menus now have light backgrounds to ensure buttons are visible in dark mode.
  • Overlay examples: Added color: CanvasText to ensure text is readable.
  • Portal examples: Dashed borders changed from black to white for better contrast in dark theme.

Changes

  • cdk-menu-nested-context-example.css: border color updated.
  • cdk-menu-standalone-menu-example.css: background for .example-standalone-trigger added with hover/active states.
  • cdk-overlay-basic-example.css: text color adjusted for dark theme.
  • cdk-portal-overview-example.css: border color updated for dark theme.

Motivation

These changes make example components readable and visually consistent in dark mode without affecting light theme appearance.

Verification

Tested all updated examples in both light and dark themes to ensure proper visibility and styling.

@pullapprove pullapprove Bot requested review from andrewseguin and crisbeto June 9, 2026 10:15
@BHUVANSH855 BHUVANSH855 force-pushed the fix-dark-theme-example-visibility branch from fca31c4 to 96c0837 Compare June 9, 2026 10:19
@BHUVANSH855

Copy link
Copy Markdown
Contributor Author

Hi @crisbeto @andrewseguin

Just checking regarding this PR.
Any feedback.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 12, 2026
@crisbeto crisbeto merged commit eb2c033 into angular:main Jun 12, 2026
34 checks passed
@crisbeto

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto pushed a commit that referenced this pull request Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants